INSTR issue with negative direction and nth direction - thinBasic: Basic Programming Language

Issue Tools
- View Changes

INSTR issue with negative direction and nth direction

17-03-2012 18:03

Petr Schreiber Petr Schreiber is offline

Super Moderator

Number of reported issues by Petr Schreiber: 109

INSTR issue with negative direction and nth direction

Incorrect results are given in case of negative direction search in conjunction with nthOccurrence parameter

Originaly reported by Klaus Heinz here: http://www.thinbasic.com/community/s...1709-INSTR-bug

Fiddling around with INSTR I encountered a bug regarding right to left searching.
Following program shows that the nth occurrence of "+" found at its correct position
searching from left to right. Doing this from right to left it just fails.
But may be I am missing something.

Regards,
Klaus Heinz

Uses "Console" 
 
' string with plus character at indexes 5, 10, 15 and 20
Dim test$ Value "----+----+----+----+"
 
' find from first index to right 
PrintL "Expect  5, get", InStr(1, test$, "+", 1)
PrintL "Expect 10, get", InStr(1, test$, "+", 2)
PrintL "Expect 15, get", InStr(1, test$, "+", 3) 
PrintL "Expect 20, get", InStr(1, test$, "+", 4) 
PrintL
' find from last index to left
PrintL "Expect 20, get", InStr(-1, test$, "+", 1)
PrintL "Expect 15, get", InStr(-1, test$, "+", 2)
PrintL "Expect 10, get", InStr(-1, test$, "+", 3) 
PrintL "Expect  5, get", InStr(-1, test$, "+", 4) 
 
WaitKey

Issue Details

Issue Number 350

Issue Type Bug

Project thinBasic

Category Core engine (thinCore.dll)

Status Fixed

Priority 2

Affected Version 1.8.9

Fixed Version 1.9.1

Milestone thinBasic 1.9.0.0

Users able to reproduce bug 1

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

17-03-2012 18:19

Petr Schreiber Petr Schreiber is offline

Super Moderator

Hot fix in the meantime:

Function INSTR_Fixed(startPosition As Long, sMainString As String, sMatchString As String, Optional nthOccurence As Long = 1) As Long
 
  Long positionFound
  
  If startPosition < 0 Then
    Long i
    Long lMain = Len(sMainString)             

    For i = 1 To nthOccurence   
      positionFound = InStr(IIf(i = 1, startPosition, -1), sMainString, sMatchString) 
      If positionFound Then
        sMainString = LEFT$(sMainString, positionFound-1)
      Else
        Exit For 
      End If 
    Next
  
    Return positionFound
  Else  
    Return InStr(startPosition, sMainString, sMatchString, nthOccurence)
  End If
                      
End Function

18-03-2012 09:55

Issue Changed by ErosOlmi

Attachment thinCore.zip uploaded

18-03-2012 09:55

ErosOlmi

thinBasic author

Attached (at the very bottom of this thread) a possible temporary fix until thinBasic 1.9 will be out.

How to install
thinCore.Zip contains thinCore.dll
Copy (replacing your current one) thinCore.dll into \thinBasic\ directory.

29-03-2012 23:29

Issue Changed by ErosOlmi

Issue marked as addressed
Addressed version changed from Unknown to 1.9.1
Milestone changed
Status changed from Unconfirmed to Fixed

+ Reply

Issue Tools